From cb084e116e4f91c1a71a417de0661c2fd494342f Mon Sep 17 00:00:00 2001 From: mcrcortex <18544518+MCRcortex@users.noreply.github.com> Date: Sat, 25 Oct 2025 16:30:08 +1000 Subject: [PATCH] actually fix the lighting of fluids (kinda) (a full fix would require a lighting comparison and taking the max of self block + neighbor bloc) --- .../client/core/rendering/building/RenderDataFactory.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/me/cortex/voxy/client/core/rendering/building/RenderDataFactory.java b/src/main/java/me/cortex/voxy/client/core/rendering/building/RenderDataFactory.java index 48436820..5d20b2d6 100644 --- a/src/main/java/me/cortex/voxy/client/core/rendering/building/RenderDataFactory.java +++ b/src/main/java/me/cortex/voxy/client/core/rendering/building/RenderDataFactory.java @@ -561,7 +561,7 @@ public class RenderDataFactory { A &= ~0b110L; A |= getQuadTyping(Am); } - long lighter = A; + long lighter = this.sectionData[bi]; //if (!ModelQueries.faceUsesSelfLighting(Am, facingForward|(axis*2))) {//TODO: check this is right // lighter = this.sectionData[bi]; //} @@ -1157,7 +1157,7 @@ public class RenderDataFactory { A &= ~0b110L; A |= getQuadTyping(Am); } - long lighter = A; + long lighter = this.sectionData[bi]; //if (!ModelQueries.faceUsesSelfLighting(Am, facingForward|(axis*2))) {//TODO: check this is right // lighter = this.sectionData[bi]; //}