From e86beefbc70a25c26b8949a3040c03073bc6dacb Mon Sep 17 00:00:00 2001 From: mcrcortex <18544518+MCRcortex@users.noreply.github.com> Date: Thu, 18 Dec 2025 22:31:15 +1000 Subject: [PATCH] rename --- .../java/me/cortex/voxy/client/core/model/ModelFactory.java | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/main/java/me/cortex/voxy/client/core/model/ModelFactory.java b/src/main/java/me/cortex/voxy/client/core/model/ModelFactory.java index 5004b4b9..47336091 100644 --- a/src/main/java/me/cortex/voxy/client/core/model/ModelFactory.java +++ b/src/main/java/me/cortex/voxy/client/core/model/ModelFactory.java @@ -446,12 +446,12 @@ public class ModelFactory { //TODO: special case stuff like vines and glow lichen, where it can be represented by a single double sided quad // since that would help alot with perf of lots of vines, can be done by having one of the faces just not exist and the other be in no occlusion mode - var sizes = this.computeModelDepth(textureData, checkMode); + var depths = this.computeModelDepth(textureData, checkMode); //TODO: THIS, note this can be tested for in 2 ways, re render the model with quad culling disabled and see if the result // is the same, (if yes then needs double sided quads) // another way to test it is if e.g. up and down havent got anything rendered but the sides do (e.g. all plants etc) - boolean needsDoubleSidedQuads = (sizes[0] < -0.1 && sizes[1] < -0.1) || (sizes[2] < -0.1 && sizes[3] < -0.1) || (sizes[4] < -0.1 && sizes[5] < -0.1); + boolean needsDoubleSidedQuads = (depths[0] < -0.1 && depths[1] < -0.1) || (depths[2] < -0.1 && depths[3] < -0.1) || (depths[4] < -0.1 && depths[5] < -0.1); boolean cullsSame = false; @@ -499,7 +499,7 @@ public class ModelFactory { for (int face = 5; face != -1; face--) {//In reverse order to make indexing into the metadata long easier long faceUploadPtr = uploadPtr + 4L * face;//Each face gets 4 bytes worth of data metadata <<= 8; - float offset = sizes[face]; + float offset = depths[face]; if (offset < -0.1) {//Face is empty, so ignore metadata |= 0xFF;//Mark the face as non-existent //Set to -1 as safepoint