From ef1a296998f9362a392fc6673a11d4c8508a4c0d Mon Sep 17 00:00:00 2001 From: mcrcortex <18544518+MCRcortex@users.noreply.github.com> Date: Wed, 17 Dec 2025 23:05:31 +1000 Subject: [PATCH] fix small possiblity of a race condition (so small is stupid yet it happened) --- src/main/java/me/cortex/voxy/common/world/other/Mapper.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/src/main/java/me/cortex/voxy/common/world/other/Mapper.java b/src/main/java/me/cortex/voxy/common/world/other/Mapper.java index 2106fd53..33d99179 100644 --- a/src/main/java/me/cortex/voxy/common/world/other/Mapper.java +++ b/src/main/java/me/cortex/voxy/common/world/other/Mapper.java @@ -185,8 +185,8 @@ public class Mapper { } entry = new StateEntry(this.blockId2stateEntry.size(), state); - this.block2stateEntry.put(state, entry); this.blockId2stateEntry.add(entry); + this.block2stateEntry.put(state, entry); this.blockLock.unlock(); byte[] serialized = entry.serialize(); @@ -208,8 +208,8 @@ public class Mapper { return entry; } entry = new BiomeEntry(this.biomeId2biomeEntry.size(), biome); - this.biome2biomeEntry.put(biome, entry); this.biomeId2biomeEntry.add(entry); + this.biome2biomeEntry.put(biome, entry); this.biomeLock.unlock(); byte[] serialized = entry.serialize(); @@ -234,7 +234,6 @@ public class Mapper { return this.blockId2stateEntry.get(blockId).state; } - //TODO: replace lambda with a class cached lambda ref (cause doing this:: still does a lambda allocation) public int getIdForBlockState(BlockState state) { if (state.isAir()) { return 0;